Uploaded image for project: 'FreeSWITCH'
  1. FreeSWITCH
  2. FS-11338

Fix git commits with multiple authors

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: core
    • Labels:
      None
    • FreeSWITCH GIT Revision:
      master
    • GIT Master Revision hash::
      master

      Description

      I can't push code up to github because github runs checks on the git history.

      There are two commits which contain two authors

      ```
      git fsck
      Checking object directories: 100% (256/256), done.
      error in commit 487128950df6ee433c131b5feaafe81ee86629f4: multipleAuthors: invalid format - multiple 'author' lines
      error in commit 8574988c3a378b4d5861ecaeb0e958657635703b: multipleAuthors: invalid format - multiple 'author' lines
      Checking objects: 100% (307936/307936), done.
      dangling blob ca8e65ad0ac3b884f4f5f8c8b0aecb576a9c42e0
      ```

      Git rules state you can't have multiple authors and the correct way to do this is to have a co-author - https://help.github.com/articles/creating-a-commit-with-multiple-authors/

      This stops people being able to use github to share code (such as the a-frame code I used at cluecon 2018) or working on freeswitch on github forks before contributing it back.

      Can we get the two offending commits fixed?

        Attachments

          Activity

            People

            • Assignee:
              mikej Mike Jerris
              Reporter:
              danjenkins Dan Jenkins
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: