Uploaded image for project: 'FreeSWITCH'
  1. FreeSWITCH
  2. FS-11637

Verto crashes when no root-password is set

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.5
    • Fix Version/s: 20.19.2, 1.8.6
    • Component/s: mod_verto
    • Labels:
      None
    • CPU Architecture:
      x86-64
    • Kernel:
      Linux
    • Userland:
      GNU/Linux
    • Distribution:
      Debian
    • Distribution Version:
      Debian 8 jessie
    • Compiler:
      gcc
    • FreeSWITCH GIT Revision:
      .
    • GIT Master Revision hash::
      .

      Description

      If someone logs in as root and the password is not set, FS crashes.

      diff --git a/src/mod/endpoints/mod_verto/mod_verto.c b/src/mod/endpoints/mod_verto/mod_verto.c
      index 6ad57d2760..d48b53430e 100644
      --- a/src/mod/endpoints/mod_verto/mod_verto.c
      +++ b/src/mod/endpoints/mod_verto/mod_verto.c
      @@ -915,7 +915,7 @@ static switch_bool_t check_auth(jsock_t *jsock, cJSON *params, int *code, char*
             }


      - if (!strcmp(login, "root")) {
      + if (!strcmp(login, "root") && jsock->profile->root_passwd) {
                     if (!(r = !strcmp(passwd, jsock->profile->root_passwd))) {
                             *code = CODE_AUTH_FAILED;
                             switch_snprintf(message, mlen, "Authentication Failure");

        Attachments

          Activity

            People

            • Assignee:
              mikej Mike Jerris
              Reporter:
              polysics Luca Pradovera
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: