Uploaded image for project: 'FreeSWITCH'
  1. FreeSWITCH
  2. FS-12008

Regression of FS-7529 due to fix for FS-11967

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.10.0
    • Fix Version/s: 20.19.6, 1.10.1
    • Component/s: freeswitch-core
    • Labels:
      None
    • CPU Architecture:
      x86-64
    • Kernel:
      Linux
    • uname:
      Linux 4.9.0-5-amd64 #1 SMP Debian 4.9.65-3+deb9u2 (2018-01-04) x86_64 GNU/Linux
    • Userland:
      GNU/Linux
    • Distribution:
      Debian
    • Distribution Version:
      Debian 9 Stretch
    • lsb_release:
      Hide
      Distributor ID: Debian
      Description: Debian GNU/Linux 9.9 (stretch)
      Release: 9.9
      Codename: stretch
      Show
      Distributor ID: Debian Description: Debian GNU/Linux 9.9 (stretch) Release: 9.9 Codename: stretch
    • Compiler:
      gcc
    • FreeSWITCH GIT Revision:
      1.10.0-release-11-7a921c608b~64bit (-release-11-7a921c608b 64bit)
    • GIT Master Revision hash::
      0ed24cfa52f3297cafdc696f0cef30286e7b5288

      Description

      In FS 1.10, I noticed a regression of FS-7529, in which the following lines are outputted to the log very frequently:

       
      2019-08-16 17:06:18.206803 [WARNING] switch_core_codec.c:723 Codec G722 Exists but not at the desired implementation. 16000hz 20ms 1ch
      2019-08-16 17:06:18.206803 [ERR] switch_core_io.c:452 sofia/external/191 Error setting BUG codec G722!
       
      Brian's fixes to FS-7529 occurred via 8ce7f24b https://freeswitch.org/stash/projects/FS/repos/freeswitch/commits/8ce7f24b and 1073b32 https://freeswitch.org/stash/projects/FS/repos/freeswitch/commits/1073b32b, in which he changed the rate passed to switch_core_codec_init() from actual_samples_per_second to samples_per_second.
       
      Then, in 1.10, Dragos fixed FS-11967 via 3bb9471e https://freeswitch.org/stash/projects/FS/repos/freeswitch/commits/3bb9471e, in which he changed the rate from samples_per_second back to actual_samples_per_second.
       
      These two fixes appear to conflict with one another, and the latter seems to have reintroduced the bug in FS-7529. The aforementioned log output does not appear in FS 1.8.7.
       
      Let me know if there's other information I can provide. I've been a FS user for the past year and appreciate all the effort that goes into this!

        Attachments

          Activity

            People

            • Assignee:
              dragos_oancea Dragos Oancea
              Reporter:
              karthikv Karthik Viswanathan
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: