Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: 1.4.19
    • Component/s: freeswitch-core
    • Security Level: public
    • Labels:
      None
    • Environment:
      Debian GNU/Linux 7
    • CPU Architecture:
      x86-64
    • Kernel:
      Linux
    • Userland:
      GNU/Linux
    • Distribution:
      Debian
    • Distribution Version:
      Debian 7 wheezy
    • Compiler:
      gcc
    • FreeSWITCH GIT Revision:
      9bf834fe58b66b7b152a6a2beb9c829cf9857c3e
    • GIT Master Revision hash::
      9bf834fe58b66b7b152a6a2beb9c829cf9857c3e

      Description

      After upgrading to last freeswitch from git freeswitch began to add :
      m=audio 0 RTP/AVP 19
      on t.38 reinvite. On version 1.4.12 all works well.
      Git reinvite:
      v=0
      o=FreeSWITCH 1414638259 1414638261 IN IP4 10.112.33.32
      s=FreeSWITCH
      c=IN IP4 10.112.33.32
      t=0 0
      m=audio 0 RTP/AVP 19
      m=image 28820 udptl t38
      a=T38FaxVersion:0
      a=T38MaxBitRate:14400
      a=T38FaxFillBitRemoval
      a=T38FaxRateManagement:transferredTCF
      a=T38FaxMaxBuffer:2000
      a=T38FaxMaxDatagram:400
      a=T38FaxUdpEC:t38UDPRedundancy
      _
      1.4.12 reinvite:
      v=0
      o=FreeSWITCH 1414645631 1414645633 IN IP4 10.112.33.32
      s=FreeSWITCH
      c=IN IP4 10.112.33.32
      t=0 0
      m=image 21834 udptl t38
      a=T38FaxVersion:0
      a=T38MaxBitRate:14400
      a=T38FaxFillBitRemoval
      a=T38FaxRateManagement:transferredTCF
      a=T38FaxMaxBuffer:2000
      a=T38FaxMaxDatagram:400
      a=T38FaxUdpEC:t38UDPRedundancy
      1. a_to_b_a_reinvites_b_t38_nomedia.pcap.gz
        3 kB
        Matteo Brancaleoni
      2. Fail - A reinvites B two SIP profiles bypass media.txt
        9 kB
        Victor Chukalovskiy
      3. Fail - A reinvites B two SIP profiles proxy media.txt
        10 kB
        Victor Chukalovskiy
      4. regression_log.txt
        6 kB
        Fran├žois
      5. sofia_glue_t38_sdp_20140224.diff
        2 kB
        Matteo Brancaleoni
      6. sofia_glue_t38_sdp_pmedia.diff
        2 kB
        Matteo Brancaleoni
      7. sofia_glue_t38_sdp.diff
        2 kB
        Matteo Brancaleoni
      8. t38_reinvite_debug_proxy_media_mode.txt
        10 kB
        Victor Chukalovskiy
      9. t38_reinvite_debug_take2.txt
        9 kB
        Victor Chukalovskiy
      10. t38_reinvite_debug.txt
        9 kB
        Victor Chukalovskiy
      11. user_variable_bypass_media_true_t38_reINVITE 2015-06-17.txt
        10 kB
        Victor Chukalovskiy

        Issue Links

          Activity

          Hide
          brian Brian West added a comment -
          Only if you can replicate the issue on demand and provide logs and details. It's not the same situation this JIRA was originally created for. So distill the data down to the situation so we can fix it
          Show
          brian Brian West added a comment - Only if you can replicate the issue on demand and provide logs and details. It's not the same situation this JIRA was originally created for. So distill the data down to the situation so we can fix it
          Hide
          sjthomason Spencer Thomason added a comment -
          Hi Brian,
          I'm getting an additional m=audio line. How is that not the same issue? Should I create a new jira?

          I believe I have a fix. Why are the tests not for:
          switch_channel_test_flag(channel, CF_PROXY_MODE) || switch_channel_test_flag(channel, CF_PROXY_MEDIA)

          instead of
          sofia_test_flag(tech_pvt, TFLAG_INB_NOMEDIA) || sofia_test_flag(tech_pvt, TFLAG_PROXY_MEDIA) in ca2dd2f3ba80924567472c0516ee8bac2af34d6a

          Would that not handle the cases better? Looking at the code, it appears that CF_PROXY_MODE and CF_PROXY_MEDIA are set by the appropriate channel variable and sofia params.

          I'm just trying to understand and do the right thing while Ive got people yelling at me ;-). I want to get this fixed as bad as everybody else.
          Show
          sjthomason Spencer Thomason added a comment - Hi Brian, I'm getting an additional m=audio line. How is that not the same issue? Should I create a new jira? I believe I have a fix. Why are the tests not for: switch_channel_test_flag(channel, CF_PROXY_MODE) || switch_channel_test_flag(channel, CF_PROXY_MEDIA) instead of sofia_test_flag(tech_pvt, TFLAG_INB_NOMEDIA) || sofia_test_flag(tech_pvt, TFLAG_PROXY_MEDIA) in ca2dd2f3ba80924567472c0516ee8bac2af34d6a Would that not handle the cases better? Looking at the code, it appears that CF_PROXY_MODE and CF_PROXY_MEDIA are set by the appropriate channel variable and sofia params. I'm just trying to understand and do the right thing while Ive got people yelling at me ;-). I want to get this fixed as bad as everybody else.
          Hide
          sjthomason Spencer Thomason added a comment -
          Hi Brian,
          Please review the PR which corrects this issue.

          Thanks!
          Spencer
          Show
          sjthomason Spencer Thomason added a comment - Hi Brian, Please review the PR which corrects this issue. Thanks! Spencer
          Hide
          anthm Anthony Minessale II added a comment -
          fyi your req has conflicts.
          Show
          anthm Anthony Minessale II added a comment - fyi your req has conflicts.
          Hide
          sjthomason Spencer Thomason added a comment -
          Hi Anthony,
          I just rebased that branch to master. Please let me know if it looks ok now.

          Thanks,
          Spencer
          Show
          sjthomason Spencer Thomason added a comment - Hi Anthony, I just rebased that branch to master. Please let me know if it looks ok now. Thanks, Spencer

            People

            • Assignee:
              anthm Anthony Minessale II
              Reporter:
              lexxua Volodymyr Fedorov
            • Votes:
              1 Vote for this issue
              Watchers:
              16 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development