Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: freeswitch-core
    • Security Level: public
    • Labels:
      None
    • Environment:
      Debian 7
    • CPU Architecture:
      x86-64
    • Kernel:
      Linux
    • Userland:
      GNU/Linux
    • Distribution:
      Debian
    • Distribution Version:
      Debian 7 wheezy
    • Compiler:
      gcc
    • Compiler Version:
      gcc version 4.7.2 (Debian 4.7.2-5)
    • FreeSWITCH GIT Revision:
      08816959aae106af9a1340ec9a283f8c7afa8ce4
    • GIT Master Revision hash::
      08816959aae106af9a1340ec9a283f8c7afa8ce4

      Description

      Configure with --disable-srtp breaks build:
      ./.libs/libfreeswitch.so: undefined reference to `srtp_unprotect_rtcp'
      collect2: error: ld returned 1 exit status

        Activity

        Hide
        sjthomason Spencer Thomason added a comment -
        Also, if --disable-srtp is added and --enable-zrtp is not added, there is an undefined label error:
        src/switch_rtp.c: In function 'switch_rtp_write_raw':
        src/switch_rtp.c:8000:2: error: label 'end' defined but not used [-Werror=unused-label]


         
        Show
        sjthomason Spencer Thomason added a comment - Also, if --disable-srtp is added and --enable-zrtp is not added, there is an undefined label error: src/switch_rtp.c: In function 'switch_rtp_write_raw': src/switch_rtp.c:8000:2: error: label 'end' defined but not used [-Werror=unused-label]  
        Hide
        sjthomason Spencer Thomason added a comment -
        Hi Mike, please review the PR. This was the only change necessary for me to get a successful build without SRTP.
        Show
        sjthomason Spencer Thomason added a comment - Hi Mike, please review the PR. This was the only change necessary for me to get a successful build without SRTP.
        Hide
        sjthomason Spencer Thomason added a comment -
        Just wanted to check in. Is it possible to merge the PR or is there any compelling reason not to fix this?

        Thanks!
        Spencer

        Show
        sjthomason Spencer Thomason added a comment - Just wanted to check in. Is it possible to merge the PR or is there any compelling reason not to fix this? Thanks! Spencer
        Hide
        mikej Mike Jerris added a comment -
        I would like to fix the real problem first before merging this.
        Show
        mikej Mike Jerris added a comment - I would like to fix the real problem first before merging this.
        Hide
        sjthomason Spencer Thomason added a comment -
        Understood. Well once/if libsrtp works on SPARC, can this be merged? If seem like the one line patch is a lot less work than removing the configure option all together but IMHO if you don't want to fix it, you should remove it. I get this is your call but I see absolutely no reason you insist on leaving it in a broken state.
        Show
        sjthomason Spencer Thomason added a comment - Understood. Well once/if libsrtp works on SPARC, can this be merged? If seem like the one line patch is a lot less work than removing the configure option all together but IMHO if you don't want to fix it, you should remove it. I get this is your call but I see absolutely no reason you insist on leaving it in a broken state.
        Hide
        anthm Anthony Minessale II added a comment -
        Please file a new bug about the sigbus error.
        This issue is regarding missing ifdef so its considered resolved with the PR
        The new issue, if created, will be to get to the bottom of the endian issue in srtp.
        Show
        anthm Anthony Minessale II added a comment - Please file a new bug about the sigbus error. This issue is regarding missing ifdef so its considered resolved with the PR The new issue, if created, will be to get to the bottom of the endian issue in srtp.

          People

          • Assignee:
            mikej Mike Jerris
            Reporter:
            sjthomason Spencer Thomason
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development