Uploaded image for project: 'FreeSWITCH'
  1. FreeSWITCH
  2. FS-9204

Snom park retrieval broken - NOTIFY sending recipient always

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: None
    • Component/s: mod_valet_parking
    • Security Level: public
    • Labels:
      None
    • Environment:
      Debian Jessie 8 tested on multiple servers
    • CPU Architecture:
      x86-64
    • Kernel:
      Linux
    • uname:
      Linux ip-10-0-44-84 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt25-2 (2016-04-08) x86_64 GNU/Linux
    • Userland:
      GNU/Linux
    • Distribution:
      Debian
    • Distribution Version:
      Debian 8 jessie
    • lsb_release:
      Hide
      No LSB modules are available.
      Distributor ID: Debian
      Description: Debian GNU/Linux 8.4 (jessie)
      Release: 8.4
      Codename: jessie
      Show
      No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 8.4 (jessie) Release: 8.4 Codename: jessie
    • Compiler:
      gcc
    • FreeSWITCH GIT Revision:
      FreeSWITCH Version 1.6.8+git~20160505T153832Z~99de0ad502~64bit (git 99de0ad 2016-05-05 15:38:32Z 64bit)
    • GIT Master Revision hash::
      FreeSWITCH Version 1.6.8+git~20160505T153832Z~99de0ad502~64bit (git 99de0ad 2016-05-05 15:38:32Z 64bit)

      Description

      Snom park retrieval doesn't work.
      tracked the issue down to mod_valet_parking like 356. If you comment that out it works but as long as "presence-call-direction" is set to something in the NOTIFY it sends a direction= recipient instead of direction=initiator

      Tested with multiple Snom phones and firmware versions as well as multipl FS servers.

      https://freeswitch.org/stash/projects/FS/repos/freeswitch/diff/src/mod/applications/mod_valet_parking/mod_valet_parking.c?until=521b3037016e276ddc8e1aae50ecaf6464b3a433&at=refs%2Fheads%2Fv1.6


      NOTIFY Examples:
      https://pastebin.freeswitch.org/view/98bf0b17#IlmrdYXgIAu81morE3ZRi8C7JrmOTPZ3 - Working

      https://pastebin.freeswitch.org/view/867ad488#qWKCdZNTlJweEPaIRzjUTigVcbflkThi - Broken

        Activity

        Hide
        markjcrane Mark J Crane added a comment -
        I've also seen this issue reverted affected server back to 1.4 release branch temporarily to resolve the issue.
        Show
        markjcrane Mark J Crane added a comment - I've also seen this issue reverted affected server back to 1.4 release branch temporarily to resolve the issue.
        Hide
        gill Gill Abada added a comment -
        Updated to 1.6.9 issue still exists.
        Show
        gill Gill Abada added a comment - Updated to 1.6.9 issue still exists.
        Hide
        gill Gill Abada added a comment -
        I opened a ticket with Snom to see if they would adjust the phones firmware. They said this:
        "This definitely looks like a bug in FreeSwitch. The remote target uri is not a valid SIP URI hence the failed INVITE on the park retrieve. Of course you know the difference between the working and non-working example is the direction="recipient" and direction="initiator' which determines if the Snom phone uses the remote or local target uri"
        Show
        gill Gill Abada added a comment - I opened a ticket with Snom to see if they would adjust the phones firmware. They said this: "This definitely looks like a bug in FreeSwitch. The remote target uri is not a valid SIP URI hence the failed INVITE on the park retrieve. Of course you know the difference between the working and non-working example is the direction="recipient" and direction="initiator' which determines if the Snom phone uses the remote or local target uri"

          People

          • Assignee:
            anthm Anthony Minessale II
            Reporter:
            gill Gill Abada
          • Votes:
            3 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development