Uploaded image for project: 'FreeSWITCH'
  1. FreeSWITCH
  2. FS-9395

Downgrade error output when video res check fails

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.8
    • Component/s: verto
    • Security Level: public
    • Labels:
      None
    • CPU Architecture:
      x86-64
    • Kernel:
      Linux
    • Userland:
      GNU/Linux
    • Distribution:
      Debian
    • Distribution Version:
      Debian 8 jessie
    • Compiler:
      gcc
    • FreeSWITCH GIT Revision:
      e2928b8a75919059277945874b5261f6fae8f7fa
    • GIT Master Revision hash::
      e2928b8a75919059277945874b5261f6fae8f7fa

      Description

      jquery.FSRTC.js contains this code for testing various camera resolutions:

      getUserMedia({
      constraints: {
                      audio: ttl++ == 0,
                      video: video
      },
      onsuccess: function(e) {
      e.getTracks().forEach(function(track) {track.stop();});
      console.info(w + "x" + h + " supported."); $.FSRTC.validRes.push([w, h]); checkRes(cam, func);},
      onerror: function(e) {console.error( w + "x" + h + " not supported."); checkRes(cam, func);}
              });

      The onerror handler throws a console.error() if the res is not supported, and this doesn't seem like a condition worthy of logging an error, perhaps more at the warn or info level? I'm suggesting this as I frequently see this message during development, and it creates more noise than signal.

      Would you accept a PR to downgrade this from an error, and if so, which of warn/info/log would you prefer? https://developer.mozilla.org/en-US/docs/Web/API/Console seems to suggest they are all about equally supported.

        Attachments

          Activity

            People

            • Assignee:
              anthm Anthony Minessale II
              Reporter:
              thehunmonkgroup Chad Phillips
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: