Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6.9, 1.6.10
    • Fix Version/s: None
    • Component/s: mod_avmd
    • Security Level: public
    • Labels:
      None
    • Environment:
      Debian
    • CPU Architecture:
      x86-64
    • Kernel:
      Linux
    • uname:
      Linux westernst 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt25-2+deb8u3 (2016-07-02) x86_64 GNU/Linux
    • Userland:
      GNU/Linux
    • Distribution:
      Debian
    • Distribution Version:
      Debian 8 jessie
    • Compiler:
      gcc
    • FreeSWITCH GIT Revision:
      FreeSWITCH version: 1.7.0+git~20160821T234605Z~c8e0eaace7~64bit (git c8e0eaa 2016-08-21 23:46:05Z 64bit)
    • GIT Master Revision hash::
      c8e0eaace7834faa39ec81c76436cfc1f8510dc7
    • Target Version:

      Description

      Currently avmd fires avmd::beep event and then sets the variable avmd_detect on the channel. This may lead to situation when the detection event is delivered before the channel has the variable set and therefore scripts like

      function onDTMFOrEvent(s, type, obj, arg) {
         try {
              if (type == "event" && session.getVariable("avmd_detect") == "TRUE") {
                  console_log("info", "Voicemail Detected\n");
                  // ...

      may not work. Fire event after channel variable has been set.

        Activity

        Hide
        piotrgregor Piotr Gregor added a comment -
        Also, set this channel variable to FALSE in avmd session's initializer.
        Show
        piotrgregor Piotr Gregor added a comment - Also, set this channel variable to FALSE in avmd session's initializer.
        Hide
        brian Brian West added a comment -
        Why would you ever bother doing the getVariable, doesn't the Beep-Status event header contain enough information to figure this out?
        Show
        brian Brian West added a comment - Why would you ever bother doing the getVariable, doesn't the Beep-Status event header contain enough information to figure this out?
        Hide
        piotrgregor Piotr Gregor added a comment -
        It does, true. Nevertheless user may want to detect beep as shown in the code snippet - as there was a question on the users mailing list recently about this. I will add to avmd documentation pages information about intended way of checking for detection, but if we can make avmd more robust by excluding possibility of bugs even when it is used not absolutely properly and it is trivial, then why not to do it.
        Show
        piotrgregor Piotr Gregor added a comment - It does, true. Nevertheless user may want to detect beep as shown in the code snippet - as there was a question on the users mailing list recently about this. I will add to avmd documentation pages information about intended way of checking for detection, but if we can make avmd more robust by excluding possibility of bugs even when it is used not absolutely properly and it is trivial, then why not to do it.

          People

          • Assignee:
            piotrgregor Piotr Gregor
            Reporter:
            piotrgregor Piotr Gregor
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development