Add extended timestamp for Type 3 chunks if necessarySection 5.3.1.3 of the RTMP spec say that type 3 packets also
should repeat this field. This matches what the parsing code (in
RTMP_ReadPacket) does.
Simplify the logic for freeing reused strings in RTMP_CloseInstead of having a plethora of flags indicating the current
state (just to avoid freeing them when closing the previous
connection when reconnecting), split RTMP_Close into CloseInternal,
taking a flag saying whether this is a reconnect or a normal,
final RTMP_Close call.
This also avoids leaks of some strings, if the whole session is
closed while the authentication process is underway.
Set RTMP_PUB_ALLOC if tcUrl is allocated in PublisherAuthThis makes sure we don't free tcUrl in RTMP_Close when reconnecting,
and avoids leaks (or simplifies code to avoid leaks).
This fixes connecting with authentication (both adobe and limelight)
when the app has been specified separately from the rest of the url.
This is only a temporary step while refactoring, this is removed
in a later commit.
Reconnect directly when authenticating, don't wait for the close messageThis fixes authentication with wowza 4.x servers, which don't
send any close message in the authentication process.
Extended timestamp field may be present in type 3 chunk headersAs described in Adobe’s RTMP specification dated 21 Dec 2012; also:
* RTMPY ticket #107, “Compressed headers also can have an extended
timestamp”,
http://web.archive.org/web/20120624031323/http://dev.rtmpy.org/ticket/107
* https://rarut.wordpress.com/2012/03/21/announcing-nginx-rtmp-module/
This resolves intermittent hangs, segfaults and crashes I was seeing when
starting ABC News 24 stre...
Correct the count of bytes written to the initial FLV bufferThis matters if the buffer overflows, when the count is used
for patching the buffer back together. This happens if there
are multiple video packets with zero timestamp at the start
of the stream (before any audio packets), enough to fill the buffer.
Include -lgmp in the pkg-config file when building with gnutlsThis is required when a user of librtmp is linking statically to
librtmp (when it is built with gnutls support).
Ideally everything of the Requires line should be in
Requires.private, and -lgmp would go into Libs.private - but if
only building a static lib, they should go where they are right
now instead. Keeping all of this where it is right now, for now,
for simplicity.
Include the nettle/hogweed crypto libraries in the pkg-config fileThese libraries are linked and used as directly as we use gnutls
itself. This fixes linking for callers if librtmp is built
statically or if the linker doesn't support transitive linking.
Fix limelight authentication with abbreviated app namesWhen streaming to limelight, the app name is either a full
"appname/subaccount" or "appname/_definst_". In the latter case,
the app name can be simplified into simply "appname", but the
authentication hashing assumes the /_definst_ still to be present.
Don't use non-public gnutls functionsThe internal functions gnutls_calc_dh_secret and gnutls_calc_dh_key
have changed signature in recent gnutls versions - don't use them
but manually do roughly the same as what they used to do before
using only public API functions.
Only use one challenge value in adobe authSome servers (akamai) only include a 'challenge' parameter, no
'opaque' parameter, while others (wowza) include both 'opaque'
and 'challenge'. If 'opaque' is provided, it should be used here,
otherwise 'challenge', but never both.
After this patch, adobe auth works against both wowza and akamai
servers.
Fix dll name to have SO_VERSION-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
subj is attached
Changes librtmp.dll into librtmp-$(SO_VERSION).dll, the same form that
libtool uses.
librtmp.dll is still created from librtmp-$(SO_VERSION).dll via `ln
- -sf'; obviously, it makes a hardlink when called in MSYS, but that's
no worse than what we have right now.
Please, CC me, since i'm not subscibed to this list
-----BEGIN PGP SI...
Add adobe authentication supportFrom: Sergiy <piratfm@gmail.com>
To use this, add flashver=FMLE/3.0\20(compatible;\20FMSc/1.0)
and pubUser=<username> pubUser=<password> to the RTMP url.
This should both work for generic adobe authentication, and for
publishing to akamai.
Allocate the channel arrays dynamicallyThis avoids having to allocate space for all theoretical channels
if most of them aren't used. This drops the size of the full
RTMP struct from over 1200 KB to 16 KB (on 64 bit), and as long as
only channels with a low number are used, the amount of total
allocated memory stays far below what it was before.
Refill if HTTP_read indicated it needs more dataHTTP_read wants to skip past the first payload byte, so
it actually needs to have at least 144 + 1 bytes buffered.
This also avoids relying on the magic 144 byte constant altogether,
which could easily break if servers include less reply headers.
Buffer more data before returning successfully from HTTP_read, if neededThis fixes issues if the http header and the payload data
are sent in separate packets (as they normally are), and the
buffer contains the full header but none of the payload.
Fix socks support for SetupURLSetupURL assigns sockshost but never parses the data. This patch factors
the code out from SetupStream into a common function and adds it to
SetupURL.
Christopher Rienzo
Ken Rice
Mike Jerris
William King
Cheolho Park
Martin Storsjo
Martin Panter
Björn Axelsson
Howard Chu
LRN
goggle1
Matthew Garrett